Skip to content

Use text colour to highlight current page/section #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Use text colour to highlight current page/section #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02830b9
use text color to highlight current section
Rich-Harris Sep 25, 2024
d305586
tweak
Rich-Harris Sep 25, 2024
90a5582
improve contrast
Rich-Harris Sep 25, 2024
f3a246f
prettier
Rich-Harris Sep 25, 2024
a55e061
contrast
Rich-Harris Sep 25, 2024
ce02a50
add subtle depth cue to make current page more visible
Rich-Harris Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/svelte.dev/src/routes/docs/[...path]/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@
left: 0;
top: var(--sk-nav-height);
overflow: hidden;

&::after {
content: '';
position: absolute;
right: 0;
top: 0;
width: 3px;
height: 100%;
background: linear-gradient(to right, transparent, rgba(0, 0, 0, 0.03));
}
}

.page {
Expand Down
13 changes: 3 additions & 10 deletions apps/svelte.dev/src/routes/docs/[...path]/OnThisPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@

a {
display: block;
color: inherit;
color: var(--sk-text-3);
box-shadow: none; /* unfortunate hack to unset some other CSS */

/* Only show the title link if it's in the sidebar */
Expand Down Expand Up @@ -156,15 +156,8 @@
display: block;
}

a.active::before {
content: '';
position: absolute;
left: -2rem;
top: calc(50% - 0.6em);
height: 1em;
width: 1em;
background: url($lib/icons/arrow-left.svg);
background-size: contain;
a.active {
color: var(--sk-text-1);
}
}
}
Expand Down
16 changes: 11 additions & 5 deletions packages/site-kit/src/lib/docs/DocsContents.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
<ul>
{#each section.children as { metadata, slug }}
<li>
<a class="page" class:active={`/${slug}` === $page.url.pathname} href="/{slug}">
<a
class="page"
aria-current={`/${slug}` === $page.url.pathname ? 'page' : undefined}
href="/{slug}"
>
{metadata.title}
</a>
</li>
Expand Down Expand Up @@ -77,6 +81,7 @@
text-transform: uppercase;
letter-spacing: 0.1em;
font-weight: 600;
color: var(--sk-text-2);
}

.page {
Expand All @@ -86,8 +91,8 @@
padding-bottom: 0.6em;
}

.active {
font-weight: 700;
[aria-current='page'] {
/* font-weight: 700; */
color: var(--sk-text-1);
}

Expand Down Expand Up @@ -121,7 +126,7 @@
background-color: var(--sk-back-4);
}

.active {
[aria-current='page'] {
background-color: hsla(var(--sk-theme-1-hsl), 0.1) !important;
color: var(--sk-theme-1) !important;
font-weight: 400;
Expand All @@ -144,7 +149,7 @@
overflow-y: auto;
}

.active::after {
[aria-current='page']::after {
--size: 1.8rem;
content: '';
position: absolute;
Expand All @@ -158,6 +163,7 @@
rotate: 45deg;
/** needed to synchronise with transition on `*` in `base.css` */
transition: background-color 0.5s var(--quint-out);
box-shadow: 0 0 3px rgba(0, 0, 0, 0.12);
}
}
</style>
16 changes: 8 additions & 8 deletions packages/site-kit/src/lib/styles/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ body {
--sk-theme-1-hsl: 12, 93%, 43%;
--sk-theme-2-hsl: 240, 8%, 44%;
--sk-theme-3-hsl: 204, 100%, 63%;
--sk-text-1: hsl(0, 0%, 13%);
--sk-text-2: hsl(0, 0%, 27%);
--sk-text-3: var(--sk-theme-2);
--sk-text-4: hsl(0, 0%, 65%);
--sk-text-1: hsla(0, 0%, 0%, 0.95);
--sk-text-2: hsla(0, 0%, 0%, 0.73);
--sk-text-3: hsla(0, 0%, 0%, 0.55);
--sk-text-4: hsla(0, 0%, 0%, 0.35);
--sk-scrollbar: rgba(0, 0, 0, 0.3);
--sk-shadow: 0px 0px 14px rgba(0, 0, 0, 0.1);

Expand Down Expand Up @@ -165,10 +165,10 @@ body {
--sk-theme-1-hsl: 12, 93%, 43%;
--sk-theme-2-hsl: 240, 8%, 44%;
--sk-theme-3-hsl: 204, 100%, 63%;
--sk-text-1: hsl(0, 0%, 13%);
--sk-text-2: hsl(0, 0%, 27%);
--sk-text-3: var(--sk-theme-2);
--sk-text-4: hsl(0, 0%, 65%);
--sk-text-1: hsla(0, 0%, 0%, 0.95);
--sk-text-2: hsla(0, 0%, 0%, 0.73);
--sk-text-3: hsla(0, 0%, 0%, 0.55);
--sk-text-4: hsla(0, 0%, 0%, 0.35);
--sk-scrollbar: rgba(0, 0, 0, 0.3);
--sk-shadow: 0px 0px 14px rgba(0, 0, 0, 0.1);

Expand Down
Loading