fix: diff highlighting for specific example in tutorial #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Marat5 is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
reviewed
Apr 4, 2025
apps/svelte.dev/content/tutorial/01-svelte/05-events/04-component-events/index.md
Outdated
Show resolved
Hide resolved
…ent-events/index.md
Rich-Harris
approved these changes
Apr 4, 2025
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all the new code is highlighted in the code example
The markdown renderer doesn't highlight full diff if it starts in the middle of another span (diff highlighting conflicts with language highlighting). So, ", decrement" is not highlighted because of this bug, it looks a little annoying to me.
Without working on renderer itself we can make it look better and just go around the bug