Skip to content

fix: prevent lifecycle_double_unmount warning in REPL #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

fix: prevent lifecycle_double_unmount warning in REPL #1288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64daba6
fix: prevent lifecycle_double_unmount warning
7nik Apr 10, 2025
4bd6f2e
prevent warning after error in a module
7nik Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/repl/src/lib/Output/Viewer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,17 @@
return untrack(() => original[method].apply(this, v));
}
}
const component = mount(App, { target: document.body });
window.__unmount_previous = () => {
for (const method of console_methods) {
console[method] = original[method];
let component;
try {
component = mount(App, { target: document.body });
} finally {
window.__unmount_previous = () => {
for (const method of console_methods) {
console[method] = original[method];
}
if (component) unmount(component);
window.__unmount_previous = null;
}
unmount(component);
}
}
//# sourceURL=playground:output
Expand Down