Skip to content

tidy up a few things #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

tidy up a few things #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/svelte.dev/src/routes/tutorial/[...slug]/OutputRollup.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
width: 100%;
height: 80%;
font: var(--sk-font-mono);
padding: 1rem;
background: var(--sk-bg-1);
border-top: 1px solid var(--sk-border);
transform: translate(0, 100%);
Expand Down
15 changes: 1 addition & 14 deletions packages/repl/src/lib/Output/Viewer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@

let logs: Log[] = $state([]);
let log_group_stack: Log[][] = [];

// svelte-ignore state_referenced_locally
let current_log_group = logs;
let last_console_event: Log;

let iframe = $state.raw<HTMLIFrameElement>();
let pending_imports = $state(0);
Expand All @@ -63,10 +63,6 @@
let ready = $state(false);
let inited = $state(false);

let log_height = 90;
let prev_height: number;
let last_console_event: Log;

onMount(() => {
proxy = new ReplProxy(iframe!, {
on_fetch_progress: (progress) => {
Expand Down Expand Up @@ -288,15 +284,6 @@
}
}

function on_toggle_console() {
if (log_height < 90) {
prev_height = log_height;
log_height = 90;
} else {
log_height = prev_height || 45;
}
}

function clear_logs() {
current_log_group = logs = [];
onLog?.(logs);
Expand Down