Skip to content

a11y tweaks #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

a11y tweaks #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b477a0
tweak some focus states
Rich-Harris Apr 16, 2025
8970592
a11y tweaks
Rich-Harris Apr 16, 2025
4f481bb
more tweaks
Rich-Harris Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/svelte.dev/src/routes/_home/Video.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@
label {
opacity: 0.2;
transition: opacity 0.2s;
border-radius: var(--sk-border-radius);
}

.top-controls {
Expand Down Expand Up @@ -237,12 +238,14 @@
border-radius: 0 var(--sk-border-radius) var(--sk-border-radius) var(--sk-border-radius);
} */

.video-player:hover label {
.video-player:hover label,
.video-player:focus-within label {
opacity: 1;
}

.video-player input:focus-visible ~ img {
outline: 2px solid var(--sk-fg-accent);
outline-offset: 2px;
border-radius: var(--sk-border-radius);
}
</style>
6 changes: 1 addition & 5 deletions packages/repl/src/lib/Output/CompilerOptions.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<!-- svelte-ignore a11y_label_has_associated_control (TODO this warning should probably be disabled if there's a component)-->
<label class="option">
<span class="key">dev:</span>
<span style="font-size: 1.2rem">
<span style="position: relative; font-size: 1.2rem; top: 0.2em">
<Checkbox
checked={workspace.compiler_options.dev!}
onchange={(dev) => {
Expand Down Expand Up @@ -70,10 +70,6 @@
color: var(--shiki-token-string);
}

label :global(input[type='checkbox']) {
top: -1px;
}

input[type='radio'] {
position: absolute;
top: auto;
Expand Down
23 changes: 11 additions & 12 deletions packages/site-kit/src/lib/components/Checkbox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@

<style>
input[type='checkbox'] {
--thumb-size: 1em;
--track-padding: 2px;
/* display: block; */
position: relative;
height: 1em;
width: 2em;
top: -2px;
height: calc(var(--thumb-size) + 2 * var(--track-padding));
width: calc(2 * var(--thumb-size) + 2 * var(--track-padding));
border-radius: 0.5em;
-webkit-appearance: none;
appearance: none;
outline: none;
border: transparent;
margin: 0 0.6em 0 0;
}
Expand All @@ -28,12 +28,11 @@
display: block;
height: 100%;
width: 100%;
padding: 2px;
border-radius: 1em;
top: 0;
left: 0;
border-radius: 9999px;
background: var(--sk-bg-4);
box-sizing: content-box;
box-sizing: border-box;
}

input[type='checkbox']:checked::before {
Expand All @@ -44,10 +43,10 @@
content: '';
position: absolute;
display: block;
height: 1em;
width: 1em;
top: 2px;
left: 2px;
height: var(--thumb-size);
aspect-ratio: 1;
top: var(--track-padding);
left: var(--track-padding);
border-radius: 1em;
background: var(--sk-bg-1);
box-shadow:
Expand All @@ -59,6 +58,6 @@
}

input[type='checkbox']:checked::after {
left: calc(100% - 1em + 2px);
left: calc(100% - var(--thumb-size) - var(--track-padding));
}
</style>
6 changes: 4 additions & 2 deletions packages/site-kit/src/lib/docs/DocsContents.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@
}

li {
position: relative;
display: block;
margin: 0;
margin-bottom: 4rem;
padding-right: 0.5rem; /* leave space for focus ring */
}

li:last-child {
Expand Down Expand Up @@ -125,14 +127,14 @@
overflow-y: auto;
}

:global(.scrollbars-invisible) [aria-current='page']::after {
:global(.scrollbars-invisible) li:has(> [aria-current='page'])::after {
--size: 1.8rem;
content: '';
position: absolute;
width: var(--size);
height: var(--size);
top: calc(1.4rem - var(--size) * 0.5);
right: calc(-0.5 * var(--size));
right: calc(-0.5rem - 0.5 * var(--size));
background-color: var(--sk-bg-1);
z-index: 2;
position: absolute;
Expand Down
12 changes: 9 additions & 3 deletions packages/site-kit/src/lib/markdown/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,9 +857,15 @@ async function syntax_highlight({
html = replace_blank_lines(highlighted);
}

// munge shiki output: put whitespace outside `<span>` elements, so that
// highlight delimiters fall outside tokens
html = html.replace(/(<span[^>]+?>)(\s+)/g, '$2$1').replace(/(\s+)(<\/span>)/g, '$2$1');
// munge shiki output
html = html
// put whitespace outside `<span>` elements, so that
// highlight delimiters fall outside tokens
.replace(/(<span[^>]+?>)(\s+)/g, '$2$1')
.replace(/(\s+)(<\/span>)/g, '$2$1')

// remove tabindex
.replace(' tabindex="0"', '');

html = html
.replace(/ {13}([^ ][^]+?) {13}/g, (_, content) => {
Expand Down
25 changes: 17 additions & 8 deletions packages/site-kit/src/lib/nav/Nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,17 @@ Top navigation bar for the application. It provides a slot for the left side, th
<Search />

<div class="external-links">
<a href="/chat" data-icon="discord" aria-label="Discord Chat"></a>
<a
href="https://bsky.app/profile/sveltesociety.dev"
data-icon="bluesky"
aria-label="Svelte Society on Bluesky"
></a>
<a href="https://github.com/sveltejs/svelte" data-icon="github" aria-label="GitHub Repo"
></a>
<a href="/chat" aria-label="Discord Chat">
<span data-icon="discord"></span>
</a>

<a href="https://bsky.app/profile/sveltesociety.dev" aria-label="Svelte Society on Bluesky">
<span data-icon="bluesky"></span>
</a>

<a href="https://github.com/sveltejs/svelte" aria-label="GitHub Repo">
<span data-icon="github"></span>
</a>
</div>

<FontToggle />
Expand Down Expand Up @@ -281,6 +284,10 @@ Top navigation bar for the application. It provides a slot for the left side, th
display: flex;
height: 100%;
margin: 0 0.5rem;

a {
outline-offset: -2px;
}
}
}

Expand Down Expand Up @@ -377,9 +384,11 @@ Top navigation bar for the application. It provides a slot for the left side, th
display: contents;

[data-icon] {
display: flex;
background: var(--sk-fg-3);
padding: 0 0.5rem;
height: 100%;
aspect-ratio: 1;
mask: no-repeat 50% 50%;
mask-size: calc(100% - 1rem) auto;
}
Expand Down
Loading