Skip to content

fix: resolve imports for local version #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix: resolve imports for local version #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/repl/src/lib/workers/bundler/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,12 @@ async function get_bundle(
}

// importing a file from the same package via pkg.imports
if (importee[0] === '#' && current) {
const subpath = resolve_subpath(current, importee);
return normalize_path(current, subpath.slice(2));
if (importee[0] === '#') {
if (current) {
const subpath = resolve_subpath(current, importee);
return normalize_path(current, subpath.slice(2));
}
return await resolve_local(importee);
}

// importing an external package -> `npm://$/<name>@<version>/<path>`
Expand Down
11 changes: 8 additions & 3 deletions packages/repl/src/lib/workers/npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,14 @@ let local_svelte_pkg: Promise<any>;
export async function resolve_local(specifier: string) {
const pkg = await (local_svelte_pkg ??= fetch(LOCAL_PKG_URL).then((r) => r.json()));

const subpath = resolve.exports(pkg, specifier.replace('svelte', '.'), {
browser: true
})![0] as string;
const subpath =
specifier[0] === '#'
? (resolve.imports(pkg, specifier, {
browser: true
})![0] as string)
: (resolve.exports(pkg, specifier.replace('svelte', '.'), {
browser: true
})![0] as string);

return new URL(subpath, LOCAL_PKG_URL).href;
}
Expand Down