feat: add svelte version selector to REPL #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dominikg
reviewed
Jul 30, 2025
|
Needs a changeset? |
|
Recent PR to REPL don't have changesets and the last release of @sveltejs/repl was two years ago. |
Rich-Harris
approved these changes
Jul 31, 2025
dummdidumm
added a commit
that referenced
this pull request
Sep 15, 2025
- on startup we had two requests each time due to the svelte version changes in #1319, and the file was always marked as changed. Fixed by not notifying when the version info comes from the bundle worker - migrate had two bundle requests, one from the direct `rebundle()` call, the second one because `update_file` invoked `on_update` that also invoked `rebundle()` -> remove the direct invocation - `reset` always did two request, because `this.set` already calls `#onreset` -> deduplicate
7nik
pushed a commit
to 7nik/svelte.dev
that referenced
this pull request
Sep 18, 2025
- on startup we had two requests each time due to the svelte version changes in sveltejs#1319, and the file was always marked as changed. Fixed by not notifying when the version info comes from the bundle worker - migrate had two bundle requests, one from the direct `rebundle()` call, the second one because `update_file` invoked `on_update` that also invoked `rebundle()` -> remove the direct invocation - `reset` always did two request, because `this.set` already calls `#onreset` -> deduplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622
I didn't make the dropdown list of available versions - it's too long, even of major only versions, plus it should allow
pr-*,branch-*,commit-*andlocalversions as well.I also did some tweaking to prevent showing the runtime and bundle errors at the same time.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.