Skip to content

fix: change github icon to link to gh organization #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2025
Merged

fix: change github icon to link to gh organization #1525

merged 5 commits into from
Sep 9, 2025

Conversation

Ocean-OS
Copy link
Member

@Ocean-OS Ocean-OS commented Sep 6, 2025 •
edited
Loading

This changes the GitHub icon in the navbar to link to the Svelte GitHub organization.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
svelte-dev Ready Ready Preview Sep 9, 2025 0:48am

dummdidumm
dummdidumm approved these changes Sep 6, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you deduplicate the logic into a function? Otherwise good to go 👍

Conduitry
Conduitry reviewed Sep 6, 2025
View reviewed changes
Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this based on the route rather than on the URL feels better to me, if that would be practical. Could we look at page.params.topic? We might then also need a separate check for page.route.id === '/docs/kit/modules'.

Separately, would we want the GH nav link to also switch to the kit repo while on Kit pages of the tutorial? I'm not sure.

Another way to do this would be to have the GH repo to link to be exposed in page data on individual pages. That would let each section of the docs make its own local decision about this, rather than needing to include everything in one place.

@Rich-Harris
Copy link
Member

Alternatively we could make it a dropdown? Might sound like overkill but it'd definitely be clearer

@Ocean-OS
Copy link
Member Author

Ocean-OS commented Sep 9, 2025

After a discussion we decided to change the GitHub icon to link to the organization.

@Ocean-OS Ocean-OS changed the title feat: relative github links fix: change github icon to link to gh organization Sep 9, 2025
@teemingc teemingc merged commit a2f28ba into main Sep 9, 2025
2 checks passed
@teemingc teemingc deleted the relative-github-links branch September 9, 2025 01:15
7nik pushed a commit to 7nik/svelte.dev that referenced this pull request Sep 18, 2025
@Ocean-OS @7nik
fix: change github icon to link to gh organization (sveltejs#1525)
f64c3af 
* feat: relative github links

* make it work with tutorials, dedupe logic

* lint

* more

* link to org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ocean-OS @Rich-Harris @dummdidumm @Conduitry @teemingc