Skip to content

fix: underlines the wrong section title #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: underlines the wrong section title #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apps/svelte.dev/src/routes/docs/[topic]/[...path]/OnThisPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,19 @@
afterNavigate(() => {
current = location.hash.slice(1);
headings = content.querySelectorAll('h2');
update(); // Ensure active link is set correctly on navigation
setTimeout(() => update(), 0); // Delay to allow layout to settle
});

// Update function to activate the correct section link
function update() {
const threshold = (innerHeight * 1) / 3;

// If scrolled less than threshold, activate the page title
if (scrollY < threshold) {
current = '';
return;
}

let found = false;

for (let i = 0; i < headings.length; i++) {
Expand All @@ -33,10 +40,7 @@
}
}

// Handle case when scrolled to the top of the page
if (!found && scrollY === 0) {
current = '';
}
// If no heading found, keep current as is
}
</script>

Expand Down