Skip to content

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 1, 2024

trying to DRY out our snippet code a bit so that #165 and #146 (comment) become a bit easier

Update: Fixes #165

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:47am

@Rich-Harris
Copy link
Member Author

fixes #165 (though the notices themselves could be improved a little, in the original JSDoc)

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like the all-italic boxes without any border or shadow, but this discussion can happen separately.

@dummdidumm dummdidumm merged commit c345928 into main Oct 2, 2024
3 checks passed
@dummdidumm dummdidumm deleted the tidy-up branch October 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show things that are deprecated
2 participants