Skip to content

Conversation

Rich-Harris
Copy link
Member

#137 (comment). I suspect this will look shitty on /playground and /tutorial but @benmccann @dummdidumm can you take a look?

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:02pm

@benmccann
Copy link
Member

I don't notice any difference or see anything scrollbar related on https://omnisite-git-naive-scrollbar-gutter-stable-svelte.vercel.app/docs/kit/$env-static-public

@Rich-Harris
Copy link
Member Author

You're saying the page still jumps around when you navigate between a page that's tall enough to need a scroll bar and one that isn't?

How does it look on /playground and /tutorial?

@benmccann
Copy link
Member

Weirdly https://svelte-omnisite.vercel.app/playground/hello-world is broken for me, but works on this branch, so it's hard to compare. All remaining pages look exactly the same. I'm not sure this PR is doing anything

@Rich-Harris
Copy link
Member Author

What kind of broken? If you mean the compiler won't start then that's annoying and needs to get fixed but it doesn't affect the question at hand.

To be absolutely clear: you're saying that the sidebar still jumps on this branch when you navigate between pages?

@benmccann
Copy link
Member

Yes, on this branch, it goes back and forth between having a scrollbar and not having one. This branch is a no-op which changes nothing for me (except for somehow making the playground load)

@Rich-Harris
Copy link
Member Author

Tried a different approach in #220

@Rich-Harris Rich-Harris closed this Oct 3, 2024
@Rich-Harris Rich-Harris deleted the naive-scrollbar-gutter-stable branch October 5, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants