Skip to content

Conversation

manuel3108
Copy link
Member

Fixes #250

removes the sorting by title, as this would place the cli before kit and svelte.
slightly changes the name of our "packages" to include ordering, as we do on a lot of docs related places.

to be done: sync the docs (didn't find the branches you were using, so always got slightly modified results)

Copy link

vercel bot commented Oct 7, 2024

@manuel3108 is attempting to deploy a commit to the Svelte team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @manuel3108 as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @manuel3108 as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Svelte team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

const packages: Package[] = [
{
name: 'svelte',
name: '10-svelte',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're removing the .sort elsewhere, do we need this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because they are ordered the same way the filesystem does, so still alphabetically

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I think the disconnect here is that I was envisaging we'd just hardcode the order in the dropdown. It seems likely that we're eventually going to want to have separators (or maybe subheads) etc...

image

...and it would be cumbersome to express that in the filesystem. The current solution using nav.json was originally built to serve multiple sites and as such is hopelessly overengineered, and I think we should just get rid of it rather than accommodating it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, then I'll just leave that up to you, you are way more aware of the codebase

@manuel3108 manuel3108 closed this Oct 8, 2024
@Conduitry Conduitry deleted the fix/custom-docs-order branch October 23, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider docs dropdown item ordering

2 participants