fix login #281
Merged
fix login #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on this so that I can properly review #275. It turns out that the staging db was paused, which was the root of #267, but beyond that the login flow seems broken because the child window (that opens when you click 'log in') tries to communicate with
window.openerwhich isn't possible. Not sure if that's a new thing caused by cross-origin isolation.Anyway we don't need direct window-to-window communication, we can hack around it with
storageevents. As soon as the child window is sent back to/auth/callback, we set a value inlocalStoragethat the parent window is listening for; once it updates, we callinvalidateAlland the child window closes.