chore: separate tutorial URLs into svelte and kit #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dummdidumm
commented
Oct 9, 2024
dummdidumm
commented
- gives us more leeway with duplicated slugs if needed later on
- makes URL a bit more organized
- will make it easier to set dedicated headers for the SvelteKit tutorial (chore: ensure full page reloads between SvelteKit tutorial and other pages (and vice versa) #301)
- fixes a bug with redirects not being picked up due to prerendering not coming across old slugs
- gives us more leeway with duplicated slugs if needed later on - makes URL a bit more organized - will make it easier to set dedicated headers for the SvelteKit tutorial (#301) - fixes a bug with redirects not being picked up due to prerendering not coming across old slugs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
looks like the deployment failed because of a bad link |
Rich-Harris
reviewed
Oct 9, 2024
apps/svelte.dev/src/routes/tutorial/[...slug]/content.server.ts
Outdated
Show resolved
Hide resolved
Good thing we have these checks in place now 😄 fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.