Skip to content

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 11, 2024

  • implement inline highlights of shiki'd code
  • convert all existing diff blocks
  • error on encountering a diff block (all diffs should use the inline form)
  • follow-up: delete the tutorial markdown rendering logic and use render_content instead

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 3:32am

@Rich-Harris
Copy link
Member Author

This has been nightmarishly complicated but I'm very happy with the change. The diffs are clearer and better looking, and we retain syntax highlighting, tooltips, and the ability to toggle between JS and TS

@Rich-Harris
Copy link
Member Author

(Oh and by not running Prettier we get more faithful conversions; often there's no change and we don't even need to bother having the two separate blocks)

@Rich-Harris Rich-Harris merged commit 50fff48 into main Oct 12, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the gh-180 branch October 12, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant