Update tutorial nav #377
Merged
Update tutorial nav #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
gah the screen toggle is hidden on mobile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tutorial nav align with the playground nav — we now have a
<select>for choosing an exercise instead of the slightly funky thing we have onmain, and the breadcrumbs go next to it, rather than being cramped into the sidebar (and frequently truncated). The 'solve' button goes to the right hand side and uses the same button styles as everywhere else, so there's no longer a big shouty thing in the middle of the page. The whole thing is just a bit calmer.There is still some room for improvement. There's no longer as clear a visual indication that you've completed an exercise (maybe adding checkmarks in the filetree could do this?), and (though it's unrelated to this PR) we have a decent chunk of real estate devoted to an address bar for the iframe even though there's nowhere to navigate to. But I think it's enough of an improvement that we can come back to that stuff later.