chore: add editor autocompletions to site-kit #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #321.
I spent forever trying to unify both editors, but I didn't want to continue to spend eternity on this – the editors are an absolute mess of hardcoded hacks bandaged on to the UI and with a few dozen or so stores. It needs a rewrite from scratch and that will likely take a good week to do right.
Instead, I unified the autocomplete so that we now get the right autocompletes for JavaScript in the tutorial.