Skip to content

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Oct 15, 2024

Partly addresses #321.

I spent forever trying to unify both editors, but I didn't want to continue to spend eternity on this – the editors are an absolute mess of hardcoded hacks bandaged on to the UI and with a few dozen or so stores. It needs a rewrite from scratch and that will likely take a good week to do right.

Instead, I unified the autocomplete so that we now get the right autocompletes for JavaScript in the tutorial.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:58pm

@Rich-Harris
Copy link
Member

The autocompletes are broken:

image

I made some progress on getting it to work properly, but it involves adding a bunch of tutorial-specific code (aka tech debt) and it's still broken — the state doesn't update when a different file is selected. I think this adventure underscores the need to do a proper refactor

@Rich-Harris Rich-Harris merged commit 3e2f01b into main Oct 15, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the move-autocomplete-site-kit branch October 15, 2024 23:59
@trueadm
Copy link
Collaborator Author

trueadm commented Oct 16, 2024

I think this adventure underscores the need to do a proper refactor

100%, I couldn't agree more, but having spent quite a bit of time today with the codebase for both editors – it's non-trivial. It's entirely up to you if you feel it takes precedence, but in the manner of keeping sanity this week, I feel it can likely wait.

I see you fixed the pathing issue – thank you. Instead of hardcoding paths for the tutorial couldn't we sanitise by local files only ./xxx? Maybe you tried that and it didn't work though?

@Rich-Harris
Copy link
Member

It should be possible to import from a parent directory, just not hidden files (and app.html is another special case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants