Skip to content

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Oct 15, 2024

Closes #354

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 6:10pm

@Rich-Harris
Copy link
Member

this isn't the right fix — that code was there for a reason. before

image

this PR:

image

@trueadm
Copy link
Collaborator Author

trueadm commented Oct 15, 2024

Meh some merge conflict issue. Fixed it sorry!

@trueadm trueadm reopened this Oct 15, 2024
@Rich-Harris
Copy link
Member

We don't want noErrors, because that will swallow errors and lead to the docs being incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS errors inside diff annotations look funky

2 participants