Skip to content

Conversation

khromov
Copy link
Contributor

@khromov khromov commented Oct 18, 2024

Lots of interesting links, no reason to send people away from the Svelte site.

Copy link

vercel bot commented Oct 18, 2024

@khromov is attempting to deploy a commit to the Svelte team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @khromov as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @khromov as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Svelte team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

@Rich-Harris
Copy link
Member

I've always felt that it should be up to the user whether a link opens in a new tab or not. If we set a target we take away their control

@Conduitry
Copy link
Member

I tend to agree with that in general, at least for sites more likely to be visited by more technical users who are more comfortable with "open this link in a new tab".

Users on mobile would be the one thing possibly giving me pause. I'm not sure.

@Rich-Harris
Copy link
Member

On Android long-pressing a link brings up a context menu that lets you open in a new tab — does iOS Safari have something similar?

@rgon
Copy link

rgon commented Oct 22, 2024

@Rich-Harris yes, it does open a context menu and also a small picture-in-picture preview of the link's href by default

@benmccann
Copy link
Member

Yeah, I'm not a big fan of this

@Conduitry
Copy link
Member

Alrighty, that's three 'no's - I'm going to go ahead and close this.

@Conduitry Conduitry closed this Oct 23, 2024
@Conduitry Conduitry deleted the external-blank branch October 23, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants