Robustify workspace #460
Merged
Robustify workspace #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work started in #430, and fixes #439 and #449. It's not what I'd call perfect — I want to move the diagnostics handling into
Workspace, and I'm not in love with the wayAppControls.sveltecalls methods exposed byRepl.svelte, though it sure is handy that that's possible — but it feels way more solid than it did before.Essentially, this moves all the
EditorStatehandling intoWorkspace, where it belongs, rather than inEditor.sveltewhere it was necessary to mess around with$effectin a convoluted and inefficient manner. Having the logic in one place makes everything somewhat easier to follow.