fix: migrate button, repl type and upgrade to ^5.0.0

[paoloricciuti]

The update to this.#current is needed when the value doesn't come from codemirror (like the migrate button) or else codemirror will not update.

This also updated to svelte 5 and fixes a typing issue in +page.svelte

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
omnisite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 20, 2024 5:25pm

[dummdidumm]

I believe there's more Svelte package references in the repo, best to bump them all

[paoloricciuti]

I've updated the rest of the packages and also the tutorial

[Conduitry]

Please also run a pnpm dedupe and make sure everything still works after that. There are a number of dependencies that now exist multiple times in different versions in the tree.

[paoloricciuti]

Uh i need to pay attention to this more. Run dedupe i'll check now that it's deployed

[paoloricciuti]

Mmm I think something broke

[Rich-Harris]

Do we have any theory as to why the editor is losing focus? I think ideally we'd fix the bug at that point, rather than adding a boolean trap, if we can avoid it

[paoloricciuti]

Do we have any theory as to why the editor is losing focus? I think ideally we'd fix the bug at that point, rather than adding a boolean trap, if we can avoid it

I think it's because by changing the file you are triggering a new "state" for code mirror which re-compute...we fixed in neo code mirror by refocusing the host if I'm not mistaken...let me check

[Rich-Harris]

States are set explicitly, and only from within the Workspace class — we're setting state inside update_file regardless of whether the update came from CodeMirror. So I think it must be something else — something responding to workspace.current changing

[paoloricciuti]

States are set explicitly, and only from within the Workspace class — we're setting state inside update_file regardless of whether the update came from CodeMirror. So I think it must be something else — something responding to workspace.current changing

Found the culprit...link was run in an effect and this.#current was accessed there...we were basically re-creating the editor view on every change.

[paoloricciuti]

Uh but now the example selectors doesn't work...let me see

[paoloricciuti]

Ok now it should be for real...man Codemirror is such a mess.

[Rich-Harris]

fantastic sleuthing!

[paoloricciuti]

sleuthing

[pretends to know what this word means without searching google] Oh yeah...sleuthing!