-
-
Notifications
You must be signed in to change notification settings - Fork 191
fix: testemonial images on safari #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- changed `filter: drop-shadow` to `box-shadow` - added a subtly larger shadow to the hover transition - moved the shadow from the `a` to the `img` and removed `overflow: hidden` from `a` - changed `filter: none` to `filter: grayscale(0)` to fix the transition on safari `overflow: hidden` caused safari to clip the shadows regardless of whether they were defined on the `a` or `img` tag for both `drop` and `box` shadows.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks like the linter is mad about |
Should I just wrap them in |
I've been ignoring those linter warnings until we figure out a more general solution! AFK so can't investigate but I wonder if adding |
I tried Edit: Turns out I'd already added |
Turns out `transfrom: translate3d(0,0,0)` was already there, but moving it from the `img` to the `a` tag did the trick!
amazing, thanks! |
filter: drop-shadow
tobox-shadow
a
to theimg
and removedoverflow: hidden
froma
filter: none
tofilter: grayscale(0)
to fix the transition on safarioverflow: hidden
caused safari to clip the shadows regardless of whether they were defined on thea
orimg
tag for bothdrop
andbox
shadows.