Skip to content

crimson pro font #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

crimson pro font #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/site-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@codemirror/state": "^6.2.1",
"@codemirror/view": "^6.17.1",
"@fontsource/dm-serif-display": "^5.1.0",
"@fontsource/eb-garamond": "^5.1.0",
"@fontsource/crimson-pro": "^5.1.0",
"@fontsource/fira-mono": "^5.1.0",
"@fontsource/fira-sans": "^5.1.0",
"@shikijs/twoslash": "^1.22.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/site-kit/src/lib/styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import '@fontsource/eb-garamond/400.css';
@import '@fontsource/eb-garamond/500.css';
@import '@fontsource/eb-garamond/400-italic.css';
@import '@fontsource/crimson-pro/400.css';
@import '@fontsource/crimson-pro/500.css';
Comment on lines +1 to +2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it using both by the way? isn't one overriding the other?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be the case, each defines the font files to use for a specific font-weight that may be set for a given element.

Though 500 is an odd choice, normal corresponds to 400 and bold is 700.
Also don't see the weight 500 being used in the codebase.

@import '@fontsource/crimson-pro/400-italic.css';
@import '@fontsource/dm-serif-display/400.css';
@import '@fontsource/dm-serif-display/400-italic.css';
@import '@fontsource/fira-mono/400.css';
Expand Down
2 changes: 1 addition & 1 deletion packages/site-kit/src/lib/styles/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

/* typography (prefer `font: --sk-font-{x}` over `font-family` and `font-size` rules */
--sk-font-family-ui: 'Fira Sans', -apple-system, sans-serif;
--sk-font-family-body: 'EB Garamond', Georgia, serif;
--sk-font-family-body: 'Crimson Pro', Georgia, serif;
--sk-font-family-heading: 'DM Serif Display', Georgia, serif;
--sk-font-family-mono: 'Fira Mono', monospace;

Expand Down
14 changes: 7 additions & 7 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading