Skip to content

make text color a tiny bit lighter in light mode #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2024
Merged

make text color a tiny bit lighter in light mode #498

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dc9a75
make text color a tiny bit lighter in dark mode
dummdidumm Oct 22, 2024
4cdd86d
Merge branch 'main' into text-color
Rich-Harris Oct 22, 2024
3f01988
tiny bit darker, only for georgia
dummdidumm Oct 22, 2024
25e2155
Merge branch 'main' into text-color
dummdidumm Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions packages/site-kit/src/lib/styles/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@

--sk-line-height-body: 1.7;

@media (resolution: 2x) {
--sk-font-family-body: 'EB Garamond', Georgia, serif;
--sk-font-size-body: 2.1rem;
--sk-font-size-body-small: 1.8rem;
--sk-line-height-body: 1.5;
}

--sk-font-h1: 500 var(--sk-font-size-h1) / 1.2 var(--sk-font-family-heading);
--sk-font-h2: 500 var(--sk-font-size-h2) / 1.2 var(--sk-font-family-heading);
--sk-font-h3: 500 var(--sk-font-size-h3) / 1.2 var(--sk-font-family-heading);
Expand All @@ -72,9 +65,9 @@
--sk-back-5: hsl(0, 0%, 92%);
--sk-back-6: hsl(0, 0%, 86%);

--sk-text-1: hsl(0, 0%, 5%);
--sk-text-2: hsl(0, 0%, 12%);
--sk-text-3: hsl(0, 0%, 27%);
--sk-text-1: hsl(0, 0%, 12%);
--sk-text-2: hsl(0, 0%, 20%);
--sk-text-3: hsl(0, 0%, 30%);
--sk-text-4: hsl(0, 0%, 45%);
--sk-scrollbar: rgba(0, 0, 0, 0.3);
--sk-shadow: drop-shadow(0px 0px 14px rgba(0, 0, 0, 0.1));
Expand Down Expand Up @@ -127,6 +120,16 @@
the 0.01 prevents Vite from optimising it to `translate(0, 0)`, which doesn't fix anything */
--safari-fix: translate3d(0, 0, 0.01);

@media (resolution: 2x) {
--sk-font-family-body: 'EB Garamond', Georgia, serif;
--sk-font-size-body: 2.1rem;
--sk-font-size-body-small: 1.8rem;
--sk-line-height-body: 1.5;
--sk-text-1: hsl(0, 0%, 5%);
--sk-text-2: hsl(0, 0%, 12%);
--sk-text-3: hsl(0, 0%, 27%);
}

&.dark {
color-scheme: dark;
-webkit-font-smoothing: antialiased;
Expand Down
Loading