convert from hsl to rgb/hex #501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Once we confirm this works well, I think it would be nice to leave the original HSL values there in comments - along with some sort of note about why we're not using them directly - so that future changes can be made more easily. A fancier build process that converts HSL to RGB is probably overkill at this point - I think just having the comments would be fine. |
|
We don't need to move away from hsl, we just need to use the old-fashioned form: -hsl(0 1 2)
+hsl(0, 1%, 2%) |
|
I'll do that instead then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422 (comment). Turns out Safari fixed hsl support in v18, before that it is majorly broken.