Skip to content

reset scroll to 0 if it wasn't restored #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

reset scroll to 0 if it wasn't restored #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions apps/svelte.dev/src/routes/tutorial/[...slug]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,12 @@

let sidebar = $state() as HTMLElement;

// TODO this doesn't seem to work any more?
export const snapshot: Snapshot<number> = {
capture: () => {
const scroll = sidebar.scrollTop;
sidebar.scrollTop = 0;
return scroll;
return sidebar.scrollTop;
},
restore: (scroll) => {
scroll_was_restored = true;
sidebar.scrollTop = scroll;
}
};
Expand Down Expand Up @@ -192,11 +190,18 @@
solution.set(b);
});

let scroll_was_restored = false;

beforeNavigate(() => {
scroll_was_restored = false;
previous_files = workspace.files;
});

afterNavigate(async () => {
if (!scroll_was_restored) {
sidebar.scrollTop = 0;
}

workspace.reset(Object.values(a), data.exercise.focus);

const will_delete = previous_files.some((file) => !(file.name in a));
Expand Down
Loading