-
-
Notifications
You must be signed in to change notification settings - Fork 190
separate code spans #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate code spans #577
Conversation
This reverts commit 7ce30c0.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/svelte.dev/content/docs/kit/20-core-concepts/30-form-actions.md
Outdated
Show resolved
Hide resolved
apps/svelte.dev/content/docs/kit/20-core-concepts/40-page-options.md
Outdated
Show resolved
Hide resolved
apps/svelte.dev/content/docs/kit/25-build-and-deploy/55-single-page-apps.md
Outdated
Show resolved
Hide resolved
apps/svelte.dev/content/docs/kit/30-advanced/10-advanced-routing.md
Outdated
Show resolved
Hide resolved
apps/svelte.dev/content/docs/kit/30-advanced/10-advanced-routing.md
Outdated
Show resolved
Hide resolved
apps/svelte.dev/content/docs/kit/98-reference/50-configuration.md
Outdated
Show resolved
Hide resolved
const cache = await caches.open(CACHE); | ||
|
||
// `build`/`files` can always be served from the cache | ||
// `build` / `files` can always be served from the cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably not strictly necessary here. I don't know whether this still makes sense to do anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may as well be consistent
…ons.md Co-authored-by: Conduitry <[email protected]>
…ons.md Co-authored-by: Conduitry <[email protected]>
…-page-apps.md Co-authored-by: Conduitry <[email protected]>
Co-authored-by: Conduitry <[email protected]>
can we automate this somehow? Like, the markdown renderer sees "there's a ` followed by a / followed by a `, I'm putting a space inbetween that ". I feel like we're going to make this mistake over and over again if we're not super careful |
Automating this via the renderer sounds good, if we can make it work properly. As Rich's initial mass-find-replace indicated, there are a lot of false positives if you're just looking for those three specific characters in a row. But maybe it might more doable in a renderer if we have access to more AST-y stuff. |
Actually transform it. |
alternative to #560. This is just a test, we would need to make the same change in the
svelte
andkit
repos