Skip to content

banner: Svelte Hack 2024 #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 25, 2024
Merged

banner: Svelte Hack 2024 #618

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
379f58a
Push
PuruVJ Oct 24, 2024
dc36b85
Oops update the link
PuruVJ Oct 24, 2024
03be7d9
Make font size bigger
PuruVJ Oct 24, 2024
f8ce24c
Update apps/svelte.dev/src/routes/banner.json/+server.js
dummdidumm Oct 24, 2024
daf1f4a
fix font
Rich-Harris Oct 24, 2024
8e41562
unhide the arrow on mobile, just looks like a weird title otherwise
Rich-Harris Oct 24, 2024
98b41aa
remove indirection
Rich-Harris Oct 24, 2024
e3cff7e
simplify
Rich-Harris Oct 24, 2024
4a7fdec
rename css var
Rich-Harris Oct 24, 2024
a1a72d5
rename
Rich-Harris Oct 24, 2024
7df3213
remove :global
Rich-Harris Oct 24, 2024
c946df8
remove text-decoration: none
Rich-Harris Oct 24, 2024
63ef4f5
simplify markdown and css
Rich-Harris Oct 24, 2024
d59ffd4
use rem
Rich-Harris Oct 25, 2024
5281b9e
finesse
Rich-Harris Oct 25, 2024
89aeab2
increase contrast
Rich-Harris Oct 25, 2024
4248ed3
change content and expiry date
Rich-Harris Oct 25, 2024
676aef3
Merge branch 'main' into banner-svelte-hack
Rich-Harris Oct 25, 2024
2325d36
tweaks
Rich-Harris Oct 25, 2024
06ab027
lint
Rich-Harris Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions apps/svelte.dev/src/routes/banner.json/+server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,15 @@ export const GET = async () => {
return json(
defineBanner([
{
id: 'advent2023',
start: new Date('1 Dec, 2023 00:00:00 UTC'),
end: new Date('24 Dec, 2023 23:59:59 UTC'),
id: 'sveltehack2024',
start: new Date('22 Oct, 2024 00:00:00 UTC'),
end: new Date('10 January, 2025 23:59:59 UTC'),
Copy link
Member

@Rich-Harris Rich-Harris Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want it to be visible for the entire duration?

Copy link
Member

@dummdidumm dummdidumm Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably makes sense to put it down mid december, you wouldn't start stuff then.

once you close it won't reappear, if that's your concern of it being annoying.

arrow: true,
content: {
lg: 'Advent of Svelte 2023 is here!',
sm: 'Advent of Svelte'
lg: 'Svelte Hack 2024 (Runes edition) is here!',
sm: 'Svelte Hack 2024'
},
href: 'https://advent.sveltesociety.dev/'
},

// This one skips the blog post and just changes the link
{
id: 'advent2023-finished',
start: new Date('25 Dec, 2023 00:00:00 UTC'),
end: new Date('1 Jan, 2024 00:00:00 UTC'),
arrow: true,
content: {
lg: 'Advent of Svelte 2023 is over. See you next year!',
sm: 'Advent of Svelte 2023 is over!'
},
href: 'https://advent.sveltesociety.dev/'
// scope: ['svelte.dev, kit.svelte.dev'] // Dont show on learn.svelte.dev by not adding it to the array
href: 'https://hack.sveltesociety.dev/2024'
}
])
);
Expand Down
2 changes: 2 additions & 0 deletions packages/site-kit/src/lib/components/Banner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@
justify-content: center;
align-items: center;

font-size: 1.7em;

overflow-y: auto;

width: 100%;
Expand Down
Loading