Skip to content

fix: implement redirects for sveltekit types #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: implement redirects for sveltekit types #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions apps/svelte.dev/src/routes/docs/[...path]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,18 @@
return;
}

const id = hash.toLowerCase().replaceAll(':', '-');
// kit/svelte4 replaced `:` character
// e.g. we want to redirect progressive-enhancement-use-enhance to Progressive-enhancement-use:enhance
// kit docs also had types in URL that we want to replace. e.g.
// https://kit.svelte.dev/docs/types#public-types-loadevent
// https://kit.svelte.dev/docs/types#private-types-cspdirectives
const id = hash
.toLowerCase()
.replaceAll(':', '-')
.replaceAll('public-types-', '')
.replaceAll('private-types-', '');

for (const heading of content.querySelectorAll('[id]')) {
// e.g. we want to redirect progressive-enhancement-use-enhance to Progressive-enhancement-use:enhance
if (heading.id.toLowerCase().replaceAll(':', '-') === id) {
goto(`#${heading.id}`, {
replaceState: true
Expand Down
Loading