Skip to content

reduce paragraph margin #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

reduce paragraph margin #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/site-kit/src/lib/styles/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ p,
ul,
ol {
font: var(--sk-font-body);
margin: 1lh 0;
margin: 0.5lh 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that 1lh seems like a lot and we could do less. it does feel a little close together now, but not by much. what do you think about giving it just a tad more at 0.6lh?

Suggested change
margin: 0.5lh 0;
margin: 0.6lh 0;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typography people like to talk about 'vertical rhythm' — that's where the 1lh came from in the first place. We're breaking that rule in a lot of places (we'd need to build the whole thing from scratch rather than merely changing the old site if we wanted to be really serious about it) but I do think that 'things should be multiples of each other' is sage advice that we should adhere to:

image

With 0.6lh, everything becomes... bumpy. Just very slightly off:

image


&:first-child {
margin-top: 0;
Expand Down
Loading