Skip to content

better tooltips #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

better tooltips #721

merged 1 commit into from
Oct 30, 2024

Conversation

Rich-Harris
Copy link
Member

Fixes #434 and improves tooltips in various ways:

  • fixes font/padding
  • adds .tooltip and .tooltip-left classes (can add .tooltip-right if we discover a need for it) that makes it easy to add a tooltip to any button with an aria-label
  • shows tooltips when button is focused, not just when it's hovered, making it more useful for sighted users that use keyboard navigation

@Rich-Harris Rich-Harris merged commit 88ece00 into main Oct 30, 2024
5 checks passed
@Rich-Harris Rich-Harris deleted the tooltips branch October 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add tooltip to migrate button
2 participants
@Rich-Harris @trueadm