Skip to content

fix: ensure correct options for Svelte 3/4 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024
Merged

fix: ensure correct options for Svelte 3/4 #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/editor/src/lib/compile-worker/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,20 @@ addEventListener('message', async (event) => {
let result: CompileResult;

if (file.name.endsWith('.svelte')) {
result = self.svelte.compile(file.contents, {
generate: options.generate, // TODO do we need to adjust this for 3/4?
const is_svelte_3_or_4 = !self.svelte.compileModule;
const compilerOptions: any = {
generate: is_svelte_3_or_4
? options.generate === 'client'
? 'dom'
: 'ssr'
: options.generate,
dev: options.dev,
modernAst: options.modernAst,
filename: file.name
});
};
if (!is_svelte_3_or_4) {
compilerOptions.modernAst = options.modernAst; // else Svelte 3/4 will throw an "unknown option" error
}
result = self.svelte.compile(file.contents, compilerOptions);
} else {
result = self.svelte.compileModule(file.contents, {
generate: options.generate,
Expand Down
Loading