Skip to content

drop the '.dev'. just 'svelte'. it's cleaner #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

drop the '.dev'. just 'svelte'. it's cleaner #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57120db
drop the '.dev'. just 'svelte'. it's cleaner
Rich-Harris Sep 24, 2024
452b223
Merge branch 'main' into fix-home-link
Rich-Harris Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions apps/svelte.dev/src/routes/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@
<Shell nav_visible={$page.route.id !== '/(authed)/repl/[id]/embed'} bind:this={shell}>
{#snippet top_nav()}
<Nav title={data.nav_title} links={data.nav_links}>
{#snippet home_large()}
<strong>svelte</strong>.dev
{/snippet}

{#snippet home_small()}
<strong>svelte</strong>
{/snippet}

{#snippet search()}
{#if $page.url.pathname !== '/search'}
<Search />
Expand Down
44 changes: 10 additions & 34 deletions packages/site-kit/src/lib/nav/Nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Top navigation bar for the application. It provides a slot for the left side, th
home_title?: string;
title: string | undefined;
links: NavigationLink[];
home_large?: Snippet;
home_small?: Snippet;
search?: Snippet;
external_links?: Snippet;
theme_label?: Snippet;
Expand All @@ -30,8 +28,6 @@ Top navigation bar for the application. It provides a slot for the left side, th
home_title = 'Homepage',
title,
links,
home_large,
home_small,
search,
external_links,
theme_label
Expand Down Expand Up @@ -82,13 +78,7 @@ Top navigation bar for the application. It provides a slot for the left side, th
aria-label="Primary"
>
<a class="home-link" href="/" title={home_title}>
<span class="home-large">
{@render home_large?.()}
</span>

<span class="home-small">
{@render home_small?.()}
</span>
<strong>svelte</strong>
</a>

{#if title}
Expand Down Expand Up @@ -234,27 +224,21 @@ Top navigation bar for the application. It provides a slot for the left side, th
background-size: auto 70%;
align-items: center;
padding-left: calc(var(--sk-page-padding-side) + 4rem);
padding-top: 5px; /* center vertically relative to logo */
text-decoration: none;
text-transform: uppercase;
letter-spacing: 0.05em;
font-size: 1.8rem;
color: var(--sk-text-4);
}

.home-small {
display: none;

margin-left: -0.75rem;
}

.home-large {
display: block;
color: var(--sk-text-4);
}
strong {
position: relative;
color: var(--sk-text-1);
font-weight: inherit;

.home-link :global(strong) {
color: var(--sk-text-1);
font-weight: inherit;
@media (min-width: 800px) {
top: 1px;
}
}
}

.mobile-menu {
Expand Down Expand Up @@ -307,14 +291,6 @@ Top navigation bar for the application. It provides a slot for the left side, th
bottom: 0;
}

.home-small {
display: block;
}

.home-large {
display: none;
}

.menu {
position: relative;
display: none;
Expand Down
Loading