Skip to content

fix: update all $state.frozen autocomplete sugestions to $state.raw #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: update all $state.frozen autocomplete sugestions to $state.raw #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
487dc58
update all $state.frozen autocomplete sugestions to $state.raw
Thiagolino8 Nov 25, 2024
f1e0a77
drive by
dummdidumm Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/svelte.dev/content/tutorial/01-svelte/03-props/03-spread-props/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ We _could_ fix it by adding the prop...
> ...in which case you can access the properties by their object paths:
>
> ```js
> console.log(stuff.name, stuff.version, stuff.description, stuff.website)
> console.log(stuff.name, stuff.version, stuff.description, stuff.website);
> ```
6 changes: 3 additions & 3 deletions packages/site-kit/src/lib/codemirror/autocompletionDataProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ const is_state = (node) => {

/**
* Returns `true` if we're already in a valid call expression, e.g.
* changing an existing `$state()` to `$state.frozen()`
* changing an existing `$state()` to `$state.raw()`
* @type {import("./types").Test}
*/
const is_state_call = (node) => {
Expand Down Expand Up @@ -583,8 +583,8 @@ export const runes = [
{ snippet: '$derived.by', test: is_state_call },
{ snippet: '$effect(() => {\n\t${}\n});', test: is_statement },
{ snippet: '$effect.pre(() => {\n\t${}\n});', test: is_statement },
{ snippet: '$state.frozen(${});', test: is_state },
{ snippet: '$state.frozen', test: is_state_call },
{ snippet: '$state.raw(${});', test: is_state },
{ snippet: '$state.raw', test: is_state_call },
{ snippet: '$bindable()', test: is_bindable },
{ snippet: '$effect.root(() => {\n\t${}\n})' },
{ snippet: '$state.snapshot(${})' },
Expand Down