fix: exclude local declarations from non-reactive property warnings (#12909)

* fix: exclude local declarations from non-reactive property warnings

* copypasta fail

Author: Rich-Harris

.changeset/perfect-pugs-shake.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: exclude local declarations from non-reactive property warnings

packages/svelte/src/compiler/phases/2-analyze/visitors/MemberExpression.js

@@ -39,7 +39,8 @@ export function MemberExpression(node, context) {
 					binding.declaration_kind === 'import' ||
 					(binding.initial &&
 						binding.initial.type !== 'ArrayExpression' &&
-						binding.initial.type !== 'ObjectExpression')
+						binding.initial.type !== 'ObjectExpression' &&
+						binding.scope.function_depth <= 1)
 				) {
 					if (parent.type !== 'MemberExpression' && parent.type !== 'CallExpression') {
 						w.reactive_declaration_non_reactive_property(node);

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-import-statement/_config.js

@@ -0,0 +1,3 @@
+import { test } from '../../test';
+
+export default test({});

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-import-statement/input.svelte

@@ -0,0 +1,8 @@
+<script>
+	import { obj } from './data.js';
+
+	$: prop = obj.prop;
+	obj.foo = 'a different prop';
+</script>
+
+<p>{prop}</p>

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-import-statement/warnings.json

@@ -0,0 +1,14 @@
+[
+	{
+		"code": "reactive_declaration_non_reactive_property",
+		"message": "Properties of objects and arrays are not reactive unless in runes mode. Changes to this property will not cause the reactive statement to update",
+		"start": {
+			"line": 4,
+			"column": 11
+		},
+		"end": {
+			"line": 4,
+			"column": 19
+		}
+	}
+]

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-self-declaration/_config.js

@@ -0,0 +1,3 @@
+import { test } from '../../test';
+
+export default test({});

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-self-declaration/input.svelte

@@ -0,0 +1,9 @@
+<script>
+	let prop;
+	$: {
+		const obj = get_obj();
+		prop = obj.prop;
+	}
+</script>
+
+<p>{prop}</p>

packages/svelte/tests/validator/samples/reactive-statement-non-reactive-self-declaration/warnings.json

@@ -0,0 +1 @@
+[]