Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 16, 2024

#13563 introduced deriveds that are "owned" or "attached" to the current active effect. In that PR the benchmarks didn't give a clear difference in terms of performance – however, it turned out that the benchmarks weren't setup to ever use an effect root, so they were never attached and thus they were always unowned. This fixes the benchmark.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: debb42e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 974e823 into main Oct 16, 2024
7 checks passed
@Rich-Harris Rich-Harris deleted the improve-benchmarking branch October 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants