Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 19, 2024

Addresses the comment made in #13660 (comment). This PR makes effect cleanup more consistent and ensures we always remove any deriveds in an effect regardless of if it's a block effect or not. I also moved the functions into effects.js as that seems a better location for them all.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: e78508a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueadm trueadm merged commit a577ce0 into main Oct 19, 2024
7 checks passed
@trueadm trueadm deleted the destroy-deriveds branch October 19, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants