Skip to content

Conversation

@paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #13631

To "keep the comment" i cleaned up the jsdoc comment a bit removing the * and the /** and */. Since a lot of stuff in the jsdoc is just JSDoc instead of an actual comment i stop at the first comment that starts with @ but i don't know if this is the right strategy. Let's talk about it.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024

🦋 Changeset detected

Latest commit: b062396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti merged commit 6ad017f into main Oct 19, 2024
7 checks passed
@paoloricciuti paoloricciuti deleted the typedef-migration-props branch October 19, 2024 19:49
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate: comments on props are either detached or deleted

4 participants