Skip to content

fix: migrate default slots to children snippet #13760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dummdidumm merged 1 commit into from
Oct 21, 2024
Merged

fix: migrate default slots to children snippet #13760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-dingos-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: migrate default slots to children snippet
4 changes: 4 additions & 0 deletions packages/svelte/src/compiler/migrate/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,6 +1152,10 @@ function migrate_slot_usage(node, path, state) {
is_text_attribute(attribute)
) {
snippet_name = attribute.value[0].data;
// the default slot in svelte 4 if what the children slot is for svelte 5
if (snippet_name === 'default') {
snippet_name = 'children';
}
if (!regex_is_valid_identifier.test(snippet_name)) {
has_migration_task = true;
state.str.appendLeft(
Expand Down
8 changes: 8 additions & 0 deletions packages/svelte/tests/migrate/samples/slot-usages/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@
<div slot="bar">bar</div>
</Component>

<Component>
<span slot="default">should be children</span>
</Component>

<Component>
<span slot="default" let:with_prop>should be children {with_prop} too</span>
</Component>

<c-e>
<div slot="named">unchanged</div>
</c-e>
10 changes: 10 additions & 0 deletions packages/svelte/tests/migrate/samples/slot-usages/output.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,16 @@
{/snippet}
</Component>

<Component>
<span >should be children</span>
</Component>

<Component>
<span >{#snippet children({ with_prop })}
should be children {with_prop} too {/snippet}
</span>
</Component>

<c-e>
<div slot="named">unchanged</div>
</c-e>