Skip to content

Conversation

@paoloricciuti
Copy link
Member

Before submitting the PR, please make sure you do the following

Closes #13773

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 85e6f6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Oct 22, 2024

Haha I just created a PR too that did exactly the same thing, you beat me to it! Well almost, we want to avoid putting try/finally on this hot path and instead we can just target the source of the issue here.

@paoloricciuti
Copy link
Member Author

Haha I just created a PR too that did exactly the same thing, you beat me to it! Well almost, we want to avoid putting try/finally on this hot path and instead we can just target the source of the issue here.

Oh great, feel free to merge yours then! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$effect.tracking() is inconsistent for custom transition function

3 participants