Skip to content

fix: date test fail for some timezone #13889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 2 commits into from
Oct 24, 2024
Merged

fix: date test fail for some timezone #13889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cae5b8
fix test for some timezone
adiguba Oct 24, 2024
9fe5590
lint
adiguba Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions packages/svelte/src/reactivity/date.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,23 @@ test('date.setDate and date.setUTCDate', () => {
date.setUTCDate(date.getUTCDate() + 1);
});

// Date/UTCDate may vary on some timezones
const date_plus_zero = new Date(initial_date);
date_plus_zero.setDate(a.getDate());
const date_plus_one = new Date(initial_date);
date_plus_one.setDate(a.getDate() + 1);
const date_plus_two = new Date(initial_date);
date_plus_two.setDate(a.getDate() + 2);

assert.deepEqual(log, [
initial_date.getDate(),
initial_date.getUTCDate(),
a.getDate(),
a.getUTCDate(),
a.getDate() + 1,
a.getUTCDate() + 1,
a.getDate() + 2,
a.getUTCDate() + 2
date_plus_zero.getDate(),
date_plus_zero.getUTCDate(),
date_plus_one.getDate(),
date_plus_one.getUTCDate(),
date_plus_two.getDate(),
date_plus_two.getUTCDate()
]);

cleanup();
Expand Down