Skip to content

fix: ensure is_pure takes into account runes #14333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Nov 19, 2024
Merged

fix: ensure is_pure takes into account runes #14333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d521b
fix: ensure is_pure takes into account runes
trueadm Nov 16, 2024
d7a8714
feedback
trueadm Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-islands-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure is_pure takes into account $effect.tracking()
10 changes: 9 additions & 1 deletion packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
/** @import { Scope } from '../../../scope' */
/** @import { NodeLike } from '../../../../errors.js' */
import * as e from '../../../../errors.js';
import { extract_identifiers, object } from '../../../../utils/ast.js';
import { extract_identifiers } from '../../../../utils/ast.js';
import * as w from '../../../../warnings.js';
import * as b from '../../../../utils/builders.js';
import { get_rune } from '../../../scope.js';

/**
* @param {AssignmentExpression | UpdateExpression} node
Expand Down Expand Up @@ -184,6 +186,7 @@ export function is_pure(node, context) {
if (node.type === 'Literal') {
return true;
}

if (node.type === 'CallExpression') {
if (!is_pure(node.callee, context)) {
return false;
Expand All @@ -195,10 +198,15 @@ export function is_pure(node, context) {
}
return true;
}

if (node.type !== 'Identifier' && node.type !== 'MemberExpression') {
return false;
}

if (get_rune(b.call(node), context.state.scope) === '$effect.tracking') {
return false;
}

/** @type {Expression | Super | null} */
let left = node;
while (left.type === 'MemberExpression') {
Expand Down
11 changes: 0 additions & 11 deletions packages/svelte/tests/runtime-legacy/samples/inline-expressions-2/_config.js
View file
Open in desktop

This file was deleted.

21 changes: 21 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/inline-expressions/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { test } from '../../test';

export default test({
html: `
<p>Without text expression: 7.36</p>
<p>With text expression: 7.36</p>
<p>With text expression and function call: 7.36</p>
<p>With text expression and property access: 4</p>
<h1>Hello name!</h1>
<p>4</p>
<h1>Tracking: true</h1>`,

ssrHtml: `
<p>Without text expression: 7.36</p>
<p>With text expression: 7.36</p>
<p>With text expression and function call: 7.36</p>
<p>With text expression and property access: 4</p>
<h1>Hello name!</h1>
<p>4</p>
<h1>Tracking: false</h1>`
});
1 change: 1 addition & 0 deletions .../samples/inline-expressions-2/main.svelte → ...es/samples/inline-expressions/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
<p>With text expression and property access: {"test".length}</p>
<h1>Hello {('name').toUpperCase().toLowerCase()}!</h1>
<p>{"test".length}</p>
<h1>Tracking: {$effect.tracking()}</h1>
Loading