chore: consolidate checks for never-static attributes #14372
Conversation
|
|
preview: https://svelte-dev-git-preview-svelte-14372-svelte.vercel.app/ this is an automated message |
|
| } | ||
|
|
||
| if (attribute.name === 'autofocus' || attribute.name === 'muted') { | ||
| if (cannot_be_set_statically(attribute.name)) { |
There was a problem hiding this comment.
Do we need this, I think we can move this entirely?
| (attribute) => | ||
| attribute.type === 'Attribute' && | ||
| (attribute.name === 'autofocus' || attribute.name === 'muted') | ||
| (attribute) => attribute.type === 'Attribute' && cannot_be_set_statically(attribute.name) |
There was a problem hiding this comment.
This logic can move to Attribute visitor rather than be here.
There was a problem hiding this comment.
I just strictly did replace the usage sites, not do any correctness fixes. This is meant to be a consolidation PR, nothing else
We're using string checks in various places, better to have it encapsulated in one function