Skip to content

chore: remove outdated TODO comment #14664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 1 commit into from
Dec 11, 2024
Merged

chore: remove outdated TODO comment #14664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/svelte/scripts/process-messages/templates/shared-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export function CODE(PARAMETER) {
error.name = 'Svelte error';
throw error;
} else {
// TODO print a link to the documentation
throw new Error(`https://svelte.dev/e/${'CODE'}`);
}
}
1 change: 0 additions & 1 deletion packages/svelte/scripts/process-messages/templates/shared-warnings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export function CODE(PARAMETER) {
normal
);
} else {
// TODO print a link to the documentation
console.warn(`https://svelte.dev/e/${'CODE'}`);
}
}
4 changes: 0 additions & 4 deletions packages/svelte/src/internal/shared/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export function invalid_default_snippet() {
error.name = 'Svelte error';
throw error;
} else {
// TODO print a link to the documentation
throw new Error(`https://svelte.dev/e/invalid_default_snippet`);
}
}
Expand All @@ -30,7 +29,6 @@ export function lifecycle_outside_component(name) {
error.name = 'Svelte error';
throw error;
} else {
// TODO print a link to the documentation
throw new Error(`https://svelte.dev/e/lifecycle_outside_component`);
}
}
Expand All @@ -47,7 +45,6 @@ export function store_invalid_shape(name) {
error.name = 'Svelte error';
throw error;
} else {
// TODO print a link to the documentation
throw new Error(`https://svelte.dev/e/store_invalid_shape`);
}
}
Expand All @@ -63,7 +60,6 @@ export function svelte_element_invalid_this_value() {
error.name = 'Svelte error';
throw error;
} else {
// TODO print a link to the documentation
throw new Error(`https://svelte.dev/e/svelte_element_invalid_this_value`);
}
}
2 changes: 0 additions & 2 deletions packages/svelte/src/internal/shared/warnings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export function dynamic_void_element_content(tag) {
if (DEV) {
console.warn(`%c[svelte] dynamic_void_element_content\n%c\`<svelte:element this="${tag}">\` is a void element — it cannot have content\nhttps://svelte.dev/e/dynamic_void_element_content`, bold, normal);
} else {
// TODO print a link to the documentation
console.warn(`https://svelte.dev/e/dynamic_void_element_content`);
}
}
Expand All @@ -32,7 +31,6 @@ export function state_snapshot_uncloneable(properties) {
${properties}`
: "Value cannot be cloned with `$state.snapshot` — the original value was returned"}\nhttps://svelte.dev/e/state_snapshot_uncloneable`, bold, normal);
} else {
// TODO print a link to the documentation
console.warn(`https://svelte.dev/e/state_snapshot_uncloneable`);
}
}
Loading