Skip to content

fix: Make Tween work with continuous target changes #14895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 3 commits into from
Jan 6, 2025
Merged

fix: Make Tween work with continuous target changes #14895

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0155f37
Read previous_value at a later stage in Tween.set
TheSpeedM Jan 5, 2025
e1feeb9
Add changeset
TheSpeedM Jan 5, 2025
287a3bd
tweak
Rich-Harris Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-cows-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: make Tween work with continuous target changes
6 changes: 3 additions & 3 deletions packages/svelte/src/motion/tweened.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export class Tween {
set(value, options) {
set(this.#target, value);

let previous_value = this.#current.v;
let previous_value = this.#current;
let previous_task = this.#task;

let started = false;
Expand All @@ -254,10 +254,10 @@ export class Tween {
if (!started) {
started = true;

fn = interpolate(/** @type {any} */ (previous_value), value);
fn = interpolate(/** @type {any} */ (previous_value.v), value);

if (typeof duration === 'function') {
duration = duration(/** @type {any} */ (previous_value), value);
duration = duration(/** @type {any} */ (previous_value.v), value);
}

previous_task?.abort();
Expand Down
Loading