-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
docs: add code of files being tested #14925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
preview: https://svelte-dev-git-preview-svelte-14925-svelte.vercel.app/ this is an automated message |
|
|
I don't understand why this fails the deployment with "has implicit any" errors, the code is correct - what am I missing? |
| get value() { | ||
| return count * mult; | ||
| }, | ||
| /** @param {number} c */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc -> TS conversion code here doesn't know how to deal with annotated methods, only function and variable declarations. We'll need to update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted that, still fails - turns out it's because of https://github.com/sveltejs/svelte.dev/blob/main/packages/site-kit/src/lib/markdown/renderer.ts#L702 where lang is always 'ts' - I have no idea how this worked until now, or if only by chance TS did fine so far. What was the reason for switching to hard-coding that as part of the shiki update in #288?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's because twoslash does not run on JS files by default - will workaround it
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
|
Mhm the preview still fails, looks like it does not incorporate changes from |
|
It's still yikes-ing locally, I get this error:
|
|
Huh I made some local changes, then reverted them, and then it built successfully? idk computers are weird |
closes #14900