Skip to content

fix: treat inert as a boolean attribute #14935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Jan 7, 2025
Merged

fix: treat inert as a boolean attribute #14935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ebc380
fix: treat `inert` as a boolean attribute
dummdidumm Jan 7, 2025
6d58e45
remove solo: true
Rich-Harris Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-planets-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: treat `inert` as a boolean attribute
2 changes: 1 addition & 1 deletion packages/svelte/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ const DOM_BOOLEAN_ATTRIBUTES = [
'formnovalidate',
'hidden',
'indeterminate',
'inert',
'ismap',
'loop',
'multiple',
Expand Down Expand Up @@ -214,7 +215,6 @@ const DOM_PROPERTIES = [
'playsInline',
'readOnly',
'value',
'inert',
'volume',
'defaultValue',
'defaultChecked',
Expand Down
17 changes: 12 additions & 5 deletions packages/svelte/tests/runtime-legacy/samples/attribute-boolean-inert/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
import { ok, test } from '../../test';
import { test } from '../../test';

export default test({
ssrHtml: `
<div></div>
<div inert="">some div <button>click</button></div>
`,

get props() {
return { inert: true };
},

test({ assert, target, component }) {
const div = target.querySelector('div');
ok(div);
assert.ok(div.inert);
const [div1, div2] = target.querySelectorAll('div');
assert.ok(!div1.inert);
assert.ok(div2.inert);

component.inert = false;
assert.ok(!div.inert);
assert.ok(!div2.inert);
}
});
1 change: 1 addition & 0 deletions packages/svelte/tests/runtime-legacy/samples/attribute-boolean-inert/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
export let inert;
</script>

<div inert={false}></div>
<div {inert}>some div <button>click</button></div>
Loading