Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cold-cups-act.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: Make Tween duration 0 set current to target immediately
11 changes: 8 additions & 3 deletions packages/svelte/src/motion/tweened.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,20 +230,25 @@ export class Tween {
set(value, options) {
set(this.#target, value);

let previous_task = this.#task;

let started = false;
let {
delay = 0,
duration = 400,
easing = linear,
interpolate = get_interpolator
} = { ...this.#defaults, ...options };

if (duration === 0) {
this.#task?.abort();
set(this.#current, value);
return Promise.resolve();
}

const start = raf.now() + delay;

/** @type {(t: number) => T} */
let fn;
let started = false;
let previous_task = this.#task;

this.#task = loop((now) => {
if (now < start) {
Expand Down
18 changes: 17 additions & 1 deletion packages/svelte/tests/motion/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import '../helpers.js'; // for the matchMedia polyfill
import { describe, it, assert } from 'vitest';
import { get } from 'svelte/store';
import { spring, tweened } from 'svelte/motion';
import { spring, tweened, Tween } from 'svelte/motion';

describe('motion', () => {
describe('spring', () => {
Expand Down Expand Up @@ -39,4 +39,20 @@ describe('motion', () => {
assert.equal(get(size), 20);
});
});

describe('Tween', () => {
it('sets immediately when duration is 0', () => {
const size = new Tween(0);

size.set(100, { duration: 0 });
assert.equal(size.current, 100);
});
});

it('updates correctly when initialized with a `null`-ish value', () => {
const size = new Tween(undefined as unknown as number, { duration: 0 });

size.set(10);
assert.equal(size.current, 10);
});
});
Loading