Skip to content

fix: ensure svelte boundaries are always appended to parent effects #14998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trueadm wants to merge 1 commit into from
Closed

fix: ensure svelte boundaries are always appended to parent effects #14998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/svelte/src/internal/client/dom/blocks/boundary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @import { Effect, TemplateNode, } from '#client' */

import { BOUNDARY_EFFECT, EFFECT_TRANSPARENT } from '../../constants.js';
import { BOUNDARY_EFFECT, EFFECT_HAS_DERIVED, EFFECT_TRANSPARENT } from '../../constants.js';
import { block, branch, destroy_effect, pause_effect } from '../../reactivity/effects.js';
import {
active_effect,
Expand Down Expand Up @@ -117,6 +117,9 @@ export function boundary(node, props, boundary_fn) {
is_creating_fallback = false;
});
});
// Since the boundary is lazy, so we need to ensure the parent
// knows that is will have children in the future
boundary.f |= EFFECT_HAS_DERIVED;
}
};

Expand Down
Loading