Skip to content

feat: allow every children in template tags #15007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Jan 14, 2025
Merged

feat: allow every children in template tags #15007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb89552
feat: allow every children in `template` tags
paoloricciuti Jan 14, 2025
2b8633d
Update .changeset/dry-mails-return.md
Rich-Harris Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-mails-return.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': minor
---

feat: allow every children in `template` tags
2 changes: 2 additions & 0 deletions packages/svelte/src/html-tree-validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ export function is_tag_valid_with_ancestor(child_tag, ancestors, child_loc, ance
export function is_tag_valid_with_parent(child_tag, parent_tag, child_loc, parent_loc) {
if (child_tag.includes('-') || parent_tag?.includes('-')) return null; // custom elements can be anything

if (parent_tag === 'template') return null; // no errors or warning should be thrown in immediate children of template tags

const disallowed = disallowed_children[parent_tag];

const child = child_loc ? `\`<${child_tag}>\` (${child_loc})` : `\`<${child_tag}>\``;
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/tests/validator/samples/invalid-node-placement-template/errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
6 changes: 6 additions & 0 deletions packages/svelte/tests/validator/samples/invalid-node-placement-template/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<template>
<tr>
<td></td>
<td></td>
</tr>
</template>
Loading